For empty id in check-operation, id needs to be handled separately#379
Merged
vnitinv merged 2 commits intoJuniper:masterfrom Oct 29, 2020
Merged
For empty id in check-operation, id needs to be handled separately#379vnitinv merged 2 commits intoJuniper:masterfrom
vnitinv merged 2 commits intoJuniper:masterfrom
Conversation
Pull Request Test Coverage Report for Build 367
💛 - Coveralls |
vnitinv
approved these changes
Oct 29, 2020
Contributor
vnitinv
left a comment
vnitinv
left a comment
There was a problem hiding this comment.
LGTM, please add UT for this PC of code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
For empty id, it doesn't check for node values.
What issues does this PR fix or reference?
For some snapshot it was causing error as id-value gave None.