Skip to content

Enhancing the logging framework for the check operator#378

Merged
vnitinv merged 3 commits intoJuniper:masterfrom
rahkumar651991:delta_oper
Oct 20, 2020
Merged

Enhancing the logging framework for the check operator#378
vnitinv merged 3 commits intoJuniper:masterfrom
rahkumar651991:delta_oper

Conversation

@rahkumar651991
Copy link
Contributor

What does this PR do?

It enhances the logging for check related operation to use user-provided logs.

What issues does this PR fix or reference?

#377 #364

Previous Behavior

If ID went missing in pre/post snapshot, hardcoded message were displayed

New Behavior

User-defined error/info log will be displayed.

@coveralls
Copy link

coveralls commented Oct 20, 2020

Pull Request Test Coverage Report for Build 363

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 308 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.1%) to 91.278%

Files with Coverage Reduction New Missed Lines %
/home/travis/virtualenv/python3.5.6/lib/python3.5/site-packages/jnpr/jsnapy/operator.py 77 92.07%
/home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/jnpr/jsnapy/operator.py 77 92.07%
/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/jnpr/jsnapy/operator.py 77 92.07%
/home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/jnpr/jsnapy/operator.py 77 92.08%
Totals Coverage Status
Change from base Build 361: -0.1%
Covered Lines: 10298
Relevant Lines: 11282

💛 - Coveralls

@vnitinv vnitinv merged commit e6a3238 into Juniper:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants