port support added for same Ip-address. #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 298
💛 - Coveralls |
vnitinv
reviewed
Jan 31, 2020
vnitinv
reviewed
Jan 31, 2020
vnitinv
reviewed
Jan 31, 2020
vnitinv
reviewed
Jan 31, 2020
vnitinv
reviewed
Jan 31, 2020
lib/jnpr/jsnapy/snap.py
Outdated
| @@ -89,6 +95,8 @@ def generate_snap_file(self, output_file, hostname, name, cmd_format): | |||
| :param cmd_format: xml/text | |||
| :return: return output file | |||
| """ | |||
| if self.port is not None: | |||
| hostname = hostname + "_" + str(self.port) | |||
There was a problem hiding this comment.
format.
hostname = "{}_{}".format(hostname, self.port)
vnitinv
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This supports connecting to same IP-address with different port number.
What issues does this PR fix or reference?
Fix for #322
Previous Behavior
Earlier the devices used to be stored with key value as the hostname. So multiple entries of same hostname but different ip-address were not supported.
New Behavior
The code is modified to store all the devices. Then one by one it tries to connects based on the hostname and other arguments provided.