FIX #284 Fixing double output when no password provided#285
Merged
vnitinv merged 1 commit intoJuniper:masterfrom Nov 21, 2017
maxdevyatov:master
Merged
FIX #284 Fixing double output when no password provided#285vnitinv merged 1 commit intoJuniper:masterfrom maxdevyatov:master
vnitinv merged 1 commit intoJuniper:masterfrom
maxdevyatov:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #284
After it hits ConnectAuthError with password is None it calls connect second time from the beginning with updated arguments.
There is no need to do the rest of the initial call, but it needs to return the result. So return added.