fixing log message and setting results variable when enabling cluster… #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… via the NETCONF API (but not via the console)
vnitinv
added a commit
that referenced
this pull request
Feb 24, 2016
fixing log message and setting results variable when enabling cluster…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… via the NETCONF API (but not via the console)
While testing the junos_srx_cluster module I discovered that the code that set the cluster via pure NETCONF (rather than NETCONF via console) has a couple of bugs.
First it was looking for the wrong response tag in the wrong location. The first line change fixes that.
Second the if block did not set the results variable. As such the module exited without the required variable being set. The second line fixes that.
If you find the changes agreeable please accept this merge request.