Skip to content

Conversation

@chidanandpujar
Copy link
Collaborator

@chidanandpujar chidanandpujar commented Aug 26, 2025

Fix for review comments
Fix for #765

1. Remove ansible from requirements.txt. 
updated the file, needs review

2. Address the [import log](https://urldefense.com/v3/__https:/console.redhat.com/ansible/automation-hub/repo/published/juniper/device/import-log/?version=1.0.8__;!!NEt6yMaO-gk!B_cMoBr1NqkR64rVItWa-YREZFpqPxm7vtiwAV-eNbms-qB9iF4mKCStYo7BqpNvPWYNwkUenIQKwnYA$) errors - MUST FIX items are the three failing sanity text and the red text at the top indicating a plugin problem.
Pending

3. Fix all links in the README file that are github-relative. Automation hub requires links in [title](full url) format.
updated, needs review.

4. Update README description to clarify junos modules. Ansible 2.1 predates collections, and the link should not point to the community Ansible package. Consider saying instead that this collection is compatible with junipernetworks.junos certified collection.
updated, Needs review.

5. Remove Ansible link in README requirement section. That points to the community Ansible package. 
changed it to https://pypi.org/project/ansible/ - Needs Review

6. Fix link under Testing in README.
Added the repo link https://github.com/Juniper/ansible-junos-stdlib.git, Needs Review.

7. Update the support section to start with something like the following:
updated the file, needs review.

8. Remove mention of opening github issues in ansible/ansible repo for junos collection.
updated the file, needs review

@chidanandpujar
Copy link
Collaborator Author

ansible-test sanity logs

(reviewvenv) root@masterhost:~/ansible_review_comments/ansible-junos-stdlib/ansible_collections/juniper/device# ansible-test sanity
Running sanity test "action-plugin-docs"
Running sanity test "ansible-doc"
Running sanity test "changelog"
Running sanity test "compile" on Python 3.8
Running sanity test "compile" on Python 3.9
WARNING: Skipping sanity test "compile" on Python 3.10 because it could not be found.
WARNING: Skipping sanity test "compile" on Python 3.11 because it could not be found.
Running sanity test "compile" on Python 3.12
WARNING: Skipping sanity test "compile" on Python 3.13 because it could not be found.
Running sanity test "empty-init"
Running sanity test "ignores"
Running sanity test "import" on Python 3.8
Running sanity test "import" on Python 3.9
WARNING: Skipping sanity test "import" on Python 3.10 because it could not be found.
WARNING: Skipping sanity test "import" on Python 3.11 because it could not be found.
Running sanity test "import" on Python 3.12
WARNING: Skipping sanity test "import" on Python 3.13 because it could not be found.
Running sanity test "line-endings"
Running sanity test "no-assert"
Running sanity test "no-get-exception"
Running sanity test "no-illegal-filenames"
Running sanity test "no-smart-quotes"
Running sanity test "pep8"
Running sanity test "pslint"
Running sanity test "pylint"
Running sanity test "replace-urlopen"
Running sanity test "runtime-metadata"
Running sanity test "shebang"
Running sanity test "shellcheck"
Running sanity test "symlinks"
Running sanity test "use-argspec-type-path"
Running sanity test "use-compat-six"
Running sanity test "validate-modules"
Running sanity test "yamllint"
WARNING: Reviewing previous 6 warning(s):
WARNING: Skipping sanity test "compile" on Python 3.10 because it could not be found.
WARNING: Skipping sanity test "compile" on Python 3.11 because it could not be found.
WARNING: Skipping sanity test "compile" on Python 3.13 because it could not be found.
WARNING: Skipping sanity test "import" on Python 3.10 because it could not be found.
WARNING: Skipping sanity test "import" on Python 3.11 because it could not be found.
WARNING: Skipping sanity test "import" on Python 3.13 because it could not be found.

@dineshbaburam91 dineshbaburam91 merged commit 39668cf into Juniper:master Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants