Skip to content

Conversation

@rsmekala
Copy link
Contributor

Fixes issue #465.

Changes

  • Move ActionModule implemetaion from module_utils/juniper_junos_common.py to action_plugins/juniper_junos_common_action.py
  • Dropped support for Juniper.junos==1.4.3 module naming e.g junos_get_facts, junos_get_config.
  • Replaced convert_to_bool_func with Ansible's implemetaion of boolean.

@rsmekala
Copy link
Contributor Author

@vnitinv Updated the code as discussed offline.

Copy link
Contributor

@vnitinv vnitinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@vnitinv
Copy link
Contributor

vnitinv commented Dec 3, 2019

@rsmekala Can you add UT result here?

@rsmekala
Copy link
Contributor Author

rsmekala commented Dec 3, 2019

ok to test

@rsmekala
Copy link
Contributor Author

rsmekala commented Dec 9, 2019

retest this please

@rsmekala
Copy link
Contributor Author

rsmekala commented Dec 9, 2019

retest this please

@rsmekala
Copy link
Contributor Author

rsmekala commented Dec 9, 2019

@vnitinv UT is passing. Please merge the PR.

Copy link
Contributor

@vnitinv vnitinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@vnitinv vnitinv merged commit 8b99e09 into Juniper:master Dec 10, 2019
@paleblued0t
Copy link

I believe we may want to add this to handle the TypeError exception that boolean throws when the value cannot be converted.

                if allow_bool_values is True:
                    # Try to convert it to a boolean value. Will be None if it
                    # can't be converted.
                    try:
                        bool_val = boolean(v)
                    except:
                        bool_val = None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants