-
Couldn't load subscription status.
- Fork 167
Restructure action_plugins implementation to fix issue in ansible==2.9 #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…n from module_utils/juniper_junos_common
- Added/Modified comments to explain the changes done - Replaced ansible.plugins.action.network.ActionModule with ansible.plugins.action.normal.ActionModule
|
@vnitinv Updated the code as discussed offline. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
|
@rsmekala Can you add UT result here? |
|
ok to test |
|
retest this please |
|
retest this please |
|
@vnitinv UT is passing. Please merge the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
|
I believe we may want to add this to handle the TypeError exception that boolean throws when the value cannot be converted. if allow_bool_values is True:
# Try to convert it to a boolean value. Will be None if it
# can't be converted.
try:
bool_val = boolean(v)
except:
bool_val = None |
Fixes issue #465.
Changes
module_utils/juniper_junos_common.pytoaction_plugins/juniper_junos_common_action.pyJuniper.junos==1.4.3module naming e.gjunos_get_facts,junos_get_config.convert_to_bool_funcwith Ansible's implemetaion ofboolean.