Skip to content

Conversation

@marioschaefer
Copy link

--diff doesn't show the diff as expected.
we changed the handling for the juniper_junos_config a bit to return the diff correctly, so that ansible is showing it.

output before the fix:

ansible-playbook sitegroups/bgp-router.yml -l XYZ -CD

PLAY [provision bgp-routers] *************************************

TASK [bgp-router : install system configuration] *************************************

changed: [XYZ]

PLAY RECAP *************************************
XYZ            : ok=4    changed=1    unreachable=0    failed=0

output after the change:

ansible-playbook sitegroups/bgp-router.yml -l XYZ -CD

PLAY [provision bgp-routers] *************************************

TASK [bgp-router : install system configuration] *************************************

[edit system root-authentication]
-   encrypted-password "asdfasdfasdf."; ## SECRET-DATA
+   encrypted-password "ddddddddd."; ## SECRET-DATA
changed: [XYZ]

PLAY RECAP *************************************
XYZ           : ok=4    changed=1    unreachable=0    failed=0

@jnpr-community-netdev
Copy link

Can one of the admins verify this patch?

1 similar comment
@jnpr-community-netdev
Copy link

Can one of the admins verify this patch?

@rsmekala
Copy link
Contributor

rsmekala commented Sep 5, 2019

@marioschaefer I think you meant to say it doesn't work when --diff option is provided through the command line. Please correct me, if I am wrong.

@vnitinv vnitinv merged commit 812a87f into Juniper:master Sep 6, 2019
jacek-izykowski pushed a commit to jacek-izykowski/ansible-junos-stdlib that referenced this pull request Sep 23, 2019
Change Juniper#427 modified behavior of juniper_junos_config (diff is not
a string anymore - it's a dict now). Behavior is now inconsistent
with the documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants