Skip to content

Conversation

@dgarros
Copy link
Contributor

@dgarros dgarros commented Feb 28, 2019

After some time we are finally getting back to this topic.

This PR is adding support for Console over SSH to all modules by adding support for 2 new parameters cs_user and cs_passwd

The way the support for Console over SSH has been implemented in Pyez, the option mode is not really required so I was not sure if we should had something specific or not.

@jnpr-community-netdev
Copy link

Can one of the admins verify this patch?

1 similar comment
@jnpr-community-netdev
Copy link

Can one of the admins verify this patch?

@rsmekala rsmekala requested a review from vnitinv September 5, 2019 09:55
@vnitinv
Copy link
Contributor

vnitinv commented Sep 5, 2019

@rsmekala @dineshbaburam91 can we cherry-pick the changes. We don't need the changes done in requirements.tzt

@rsmekala rsmekala removed the request for review from vnitinv September 6, 2019 05:42
Copy link
Contributor

@rsmekala rsmekala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vnitinv It will be hard to cherry-pick the file. Also, there is no change in requirements.txt.

Approving this request.

@rsmekala
Copy link
Contributor

rsmekala commented Sep 6, 2019

@dgarros Thanks for the contribution. Merging this (finally 😄 )

@rsmekala rsmekala merged commit 7fc5bd1 into Juniper:master Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants