Logging level #359
Logging level #359
Conversation
| higher are logged. | ||
| - 4) If I(level) is mentioned then messages at level I(level) or more are | ||
| logged. | ||
There was a problem hiding this comment.
Please make sure the documentation generates correctly with this addition. The documentation generation can be very fragile.
module_utils/juniper_junos_common.py
Outdated
| logging_spec_mutually_exclusive = ['logfile', 'logdir'] | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Why add extra unnecessary whitespace? Suggest you always run pep8 against your changes.
module_utils/juniper_junos_common.py
Outdated
| argument_spec.update(top_spec) | ||
| # Extend mutually_exclusive with connection_mutually_exclusive | ||
| mutually_exclusive += top_spec_mutually_exclusive | ||
| mutually_exclusive = top_spec_mutually_exclusive |
There was a problem hiding this comment.
This will break things! A module may specify parameters which are mutually exclusive. The common parameters which are mutually exclusive should be added to the module specified parameters, not override them.
|
@rsmekala Can you please clean up unwanted commits |
…ction" This reverts commit 9804d2b.
|
@rsmekala you added a commit that reverts the |
|
Fix #359 |
|
@rsmekala This pull request is clean as of now with respect to other changes in the discussion. So I think we are good. |
4 participants
Fix for issue #354
Added level option to logging specifications. User can use
leveloption in task to set the verbosity level for Juniper.junos role.User can choose of either INFO/DEBUG logging level. The default level would be WARNING.
The order of preference for setting the level would be: