Skip to content

Fix acceptable_percent_loss parameter to juniper_junos_ping. #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2018
Merged

Fix acceptable_percent_loss parameter to juniper_junos_ping. #330

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions library/juniper_junos_ping.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,7 +521,7 @@ def main():
# Results should include all the ping params in argument_spec_keys.
for key in argument_spec_keys:
results[key] = params.get(key)
# Overrite to be a string in the results
# Overwrite to be a string in the results
results['acceptable_percent_loss'] = str(
params.get('acceptable_percent_loss'))
# Add timeout to the response even though it's a connect parameter.
Expand All @@ -534,7 +534,7 @@ def main():
# Execute the ping.
results = junos_module.ping(
ping_params,
acceptable_percent_loss=['acceptable_percent_loss'],
acceptable_percent_loss=params['acceptable_percent_loss'],
results=results)

# Return results.
Expand Down