Skip to content

Fix do_not_fragment argument to junos_ping module #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 19, 2017
Merged

Fix do_not_fragment argument to junos_ping module #264

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b3a2f4a
Preparing for v.1.4.1 release.
stacywsmith Apr 21, 2017
13150b3
Merge remote-tracking branch 'upstream/master'
stacywsmith Apr 24, 2017
16ecb46
Merge remote-tracking branch 'upstream/master'
stacywsmith Apr 24, 2017
4e3bd87
Merge remote-tracking branch 'upstream/master'
stacywsmith Apr 24, 2017
0235454
Merge remote-tracking branch 'upstream/master'
stacywsmith Apr 24, 2017
e93433f
Merge remote-tracking branch 'upstream/master'
stacywsmith Aug 23, 2017
f4fe154
Merge remote-tracking branch 'upstream/master'
stacywsmith Sep 18, 2017
409e35e
Fix regression caused by #262.
stacywsmith Sep 19, 2017
3ad3742
Add size argument required for do_not_fragment to be useful.
stacywsmith Sep 19, 2017
9b33edb
Debugging failure of junos_ping TEST 5.
stacywsmith Sep 19, 2017
3ecd419
Properly set rapid and do_not_fragment options as booleans.
stacywsmith Sep 19, 2017
25d55f5
Remove Ansible 1.9.6 from testing. Tests use a filter only present in…
stacywsmith Sep 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions library/junos_ping
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,12 +181,13 @@ def main():
dest_ip=dict(required=True, default=None),
source_ip=dict(required=False, default=None),
interface=dict(required=False, default=None),
rapid=dict(required=False, default=True),
rapid=dict(required=False, type='bool', default=True),
routing_instance=dict(required=False, default=None),
ttl=dict(required=False, default=None),
acceptable_packet_loss=dict(required=False, default=0),
count=dict(required=False, default='5'),
do_not_fragment=dict(required=False, default=False)
size=(dict(required=False, default=None)),
do_not_fragment=dict(required=False, type='bool', default=False)
),
supports_check_mode=False
)
Expand Down Expand Up @@ -237,7 +238,7 @@ def main():
if m_args['rapid'] is True:
ping_params['rapid'] = m_args['rapid']

if m_args['do_not_fragment']:
if m_args['do_not_fragment'] is True:
ping_params['do_not_fragment'] = m_args['do_not_fragment']

if m_args['source_ip'] is not None:
Expand All @@ -256,6 +257,10 @@ def main():
ping_params['ttl'] = str(m_args['ttl'])
results['ttl'] = str(m_args['ttl'])

if m_args['size'] is not None:
ping_params['size'] = str(m_args['size'])
results['size'] = str(m_args['size'])

## Change default Timeout
timeout = int(m_args['timeout'])
if timeout > 0:
Expand Down