Add do_not_fragment to junos_ping #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mkomon
commented
Sep 16, 2017
mkomon
commented
- add option to set DF bit
* add option to set DF bit
stacywsmith
approved these changes
Sep 18, 2017
stacywsmith
added a commit
that referenced
this pull request
Sep 19, 2017
Fix regression caused by #262. If the `do_not_fragment` argument was not set by the user, the default settings caused an incorrect value of `'False'` to be passed to the ping RPC. * Add size argument required for do_not_fragment to be useful. * Debugging failure of junos_ping TEST 5. * Properly set rapid and do_not_fragment options as booleans. * Remove Ansible 1.9.6 from testing. Tests use a filter only present in >= 2.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.