Allow modules to import cleanly #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compatible with Ansible 2.3 which tries to import them to see if `USE_PERSISTENT_CONNECTION` is set.
vnitinv
approved these changes
Mar 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ansible 2.3 attempts to import modules to see if
USE_PERSISTENT_CONNECTIONis set. The modules are incorrectly executed upon import because they lack aif __name__ == '__main__':conditional.This is an alternate way to address ansible/ansible#22590. I suggest that ansible/ansible#22590 should still be merged to avoid the problem for users which are running a version of these modules which don't yet have this fix.