Modify junos_get_facts to be compatible with Juniper/py-junos-eznc#638. #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ansible 2 doesn't like custom objects in a module's return value, and after py-junos-eznc#638 PyEZ facts are now a custom object rather than a true dict. Since facts are read-only, we must begin by copying facts into a dict. Also, since PyEZ facts are now "on-demand", this must be done before closing the connection. These changes remain backwards compatible with older PyEZ versions that have older fact gathering code.
stacywsmith
added a commit
that referenced
this pull request
Apr 6, 2017
#224) After Juniper/py-junos-eznc#638, PyEZ facts are now a custom object rather than a true dict. In addition, facts are now read-only. This was partially addressed in #210, but I missed the case where the `savedir` option is specified to dump the facts into JSON files. The same fix is also required in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ansible 2 doesn't like custom objects in a module's return value, and
after Juniper/py-junos-eznc#638 PyEZ facts are now a custom object rather than a true
dict. Since facts are read-only, we must begin by copying facts into a dict.
Also, since PyEZ facts are now "on-demand", this must be done before closing
the connection. These changes remain backwards compatible with older PyEZ
versions that have older fact gathering code.