Skip to content

[junos_jsnapy] Clean up the inline documentation #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 22, 2016
Merged

[junos_jsnapy] Clean up the inline documentation #197

merged 1 commit into from
Dec 22, 2016

Conversation

@dgarros
Copy link
Contributor

@dgarros dgarros commented Dec 22, 2016

  • Remove dest option from doc,
  • Indicate action as mandatory in doc,
  • Add examples for snap_pre & snap_post

stacywsmith
stacywsmith approved these changes Dec 22, 2016
View reviewed changes
Copy link
Contributor

@stacywsmith stacywsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@vnitinv vnitinv merged commit 0d90675 into Juniper:master Dec 22, 2016
@dgarros dgarros deleted the fix_jsnapy_doc branch December 22, 2016 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@vnitinv vnitinv vnitinv approved these changes

@stacywsmith stacywsmith stacywsmith approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dgarros @vnitinv @stacywsmith