Skip to content

Conversation

@yurilaaziz
Copy link
Contributor

We get this error last week on our Rhel7 server.

@stacywsmith
Copy link
Contributor

@yurilaaziz

This fix makes sense for the setup.py file in order for the modules to be correctly installed. I will merge this pull request. Thanks for submitting it.

This isn't directly applicable to your commit, but it's worth stating here for future reference.

Using /usr/bin/env is not the recommended approach within modules themselves. For modules, the shebang line of the modules should be set to #!/usr/bin/python and the ansible_python_interpreter variable should be used as needed to specify an non-default Python2 location.

See: this reference or
that reference

The modules don't currently comply with this recommendation. They currently have /usr/bin/env in the shebang line instead. We should probably address that under a separate issue.

@stacywsmith stacywsmith merged commit b91c6f9 into Juniper:master Nov 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants