juniper_junos_config - wrong filename when retrieving config

[kr3ator]

Issue Type

• Bug Report
• Documentation Report

Module Name

juniper_junos_config

Juniper.Junos role and Python libraries version

ansible 2.8.6
  config file = ~/ansible.cfg
  configured module search path = [u'~/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = ~/.local/lib/python2.7/site-packages/ansible
  executable location =~/.local/bin/ansible
  python version = 2.7.15+ (default, Oct  7 2019, 17:39:04) [GCC 7.4.0]

junos-eznc==2.3.0
Juniper.junos==2.2.1

OS / Environment

vMX 19.1

Summary

I want to save configuration files in a set format from my vMX devices. The documentation states that it should be saved to the specified folder under the name of "{{ inventory_hostname }}.format".
But that's not the case, because the files are saved under "{{ ansible_host }}.format" filenames.

Please either correct the documentation or (better) change the variable to use invnetory_hostname.

Steps to reproduce

Use juniper_junos_config module to get configs from hosts where your hosts have a defined ansible_host variable.

  - name: Get Junos config
    juniper_junos_config:
      ssh_config: "{{ playbook_dir }}/ssh_config"
      passwd: "{{ ansible_password }}"
      timeout: 60
      dest_dir: log
      retrieve: committed
      return_output: false
      format: set

Expected results

Config files under log/ directory:
vmx1.set
vmx2.set

Actual results

Config files under log/ directory:
192.168.255.2.set
192.168.255.6.set

[rsmekala]

@kr3ator Currently, the module doesn't get the inventory_hostname parameter from Ansible, so this enhancement will require native support from Ansible.

I have already raised a question with the Ansible team. Please do take a look at it for more details.
https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!topic/ansible-project/tpAXYUShJ-g

[steffann]

I don't think this is ansible's fault. It seems to be cause here:

ansible-junos-stdlib/action_plugins/juniper_junos_common_action.py

Lines 89 to 94 in 909b382

	for key in connection_spec_fallbacks:
	if key not in connection_args:
	for task_var_key in connection_spec_fallbacks[key]:
	if task_var_key in task_vars:
	new_connection_args[key] = task_vars[task_var_key]
	break

with

connection_spec_fallbacks = {
    'host': ['ansible_host', 'inventory_hostname'],
    …
}

But it's easy to also pass along the inventory_hostname. Writing a patch now!