Fix Live Activity silent start, token upsert, and stale token deletion bug#133
Merged
JulianKahnert merged 1 commit intodevelopfrom Feb 19, 2026
Merged
Conversation
…n bug - PushNotificationService: start Live Activity silently (no banner) by sending APNSStartLiveActivityNotification with empty alert content; alert is only triggered after maxOpenDuration via sendNotification - PushNotificationService: fix inverted filter that deleted all tokens instead of just the specific stale liveActivityUpdate token - OpenAPIController: replace delete+insert with upsert pattern for device tokens to avoid race conditions and duplicate entries - FlowKitAdapter: replace .onChange(of: serverAddress) + .task with .task(id: serverAddress) so runloop restarts automatically on address change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
APNSStartLiveActivityNotificationwird jetzt mit leeremAPNSAlertNotificationContent()gesendet – kein Banner beim Starten der Live Activity. Der eigentliche Alert kommt erst nachmaxOpenDurationviasendNotification..filter(\.$id != tokenId)) hat ALLE anderen Tokens gelöscht statt nur den alten Token. Korrigiert auf.filter(\.$id == tokenId).OpenAPIControllernutzt jetzt ein Upsert-Pattern (update wenn vorhanden, sonst insert) statt delete+insert für Device Tokens – robuster gegen Race Conditions..onChange(of: serverAddress)+.taskersetzt durch.task(id: serverAddress), sodass der Runloop automatisch bei Server-Adressänderung neu startet.Test plan
maxOpenDuration→ Alert-Notification wird gesendet