-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed is_windows
to Sys.iswindows
#43
Conversation
You've got to update travis and appveyor to test only from v0.7 |
@ranjanan Thanks! But should I just updated it so they test v0.7 and up, or should I try to make it compatible with older versions somehow? |
Test will only be run for Julia v0.7 and above
To make the package compatible with v1.0
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
========================================
+ Coverage 9.09% 100% +90.9%
========================================
Files 2 1 -1
Lines 11 1 -10
========================================
Hits 1 1
+ Misses 10 0 -10 Continue to review full report at Codecov.
|
I think dropping until v0.6 is fine. Also, have you seen #42? It may make sense to just merge efforts there. |
Not yet, but thanks for showing it to me. I played around more and I saw that these things should also be changed. I look at #42 maybe I can help there. |
#42 is now merged. Note that Julia 1.0 doesn't quite work yet. |
Changed
is_windows
toSys.iswindows
because it was deprecated with JuliaLang/julia#22182