Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed is_windows to Sys.iswindows #43

Closed
wants to merge 5 commits into from
Closed

Conversation

danimad
Copy link

@danimad danimad commented Aug 11, 2018

Changed is_windows to Sys.iswindows because it was deprecated with JuliaLang/julia#22182

@ranjanan
Copy link
Contributor

You've got to update travis and appveyor to test only from v0.7

@danimad
Copy link
Author

danimad commented Aug 12, 2018

@ranjanan Thanks! But should I just updated it so they test v0.7 and up, or should I try to make it compatible with older versions somehow?
I'm just getting into Julia, and wanted to try out Queryverse with v1.0, and now I try to fix the errors on my local machines. Maybe it was a bit presumptuous to do PLs until I learned more about Julia. 😄

Test will only be run for Julia v0.7 and above
To make the package compatible with v1.0
@codecov-io
Copy link

codecov-io commented Aug 12, 2018

Codecov Report

Merging #43 into master will increase coverage by 90.9%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #43      +/-   ##
========================================
+ Coverage    9.09%   100%   +90.9%     
========================================
  Files           2      1       -1     
  Lines          11      1      -10     
========================================
  Hits            1      1              
+ Misses         10      0      -10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94c22f4...7ef8152. Read the comment docs.

@ranjanan
Copy link
Contributor

I think dropping until v0.6 is fine. Also, have you seen #42? It may make sense to just merge efforts there.

@danimad
Copy link
Author

danimad commented Aug 12, 2018

Not yet, but thanks for showing it to me. I played around more and I saw that these things should also be changed. I look at #42 maybe I can help there.

@omus
Copy link
Collaborator

omus commented Aug 13, 2018

#42 is now merged. Note that Julia 1.0 doesn't quite work yet.

@omus omus closed this Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants