Skip to content

Commit

Permalink
Do not migrate tasks to a different thread pool (#1159)
Browse files Browse the repository at this point in the history
  • Loading branch information
@samtkaplan
samtkaplan authored Mar 16, 2024
1 parent 57101ba commit c495600
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
4 changes: 2 additions & 2 deletions Project.toml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "HTTP"
uuid = "cd3eb016-35fb-5094-929b-558a96fad6f3"
authors = ["Jacob Quinn", "contributors: https://github.com/JuliaWeb/HTTP.jl/graphs/contributors"]
version = "1.10.3"
version = "1.10.4"

[deps]
Base64 = "2a0f44e3-6c83-55bd-87e4-b1978d98bd5f"
Expand All @@ -22,7 +22,7 @@ UUIDs = "cf7118a7-6976-5b1a-9a39-7adc72f591a4"

[compat]
CodecZlib = "0.7"
ConcurrentUtilities = "2.2"
ConcurrentUtilities = "2.4"
ExceptionUnwrapping = "0.1"
LoggingExtras = "0.4.9,1"
MbedTLS = "0.6.8, 0.7, 1"
Expand Down
5 changes: 3 additions & 2 deletions src/clientlayers/StreamRequest.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ module StreamRequest
using ..IOExtras, ..Messages, ..Streams, ..Connections, ..Strings, ..RedirectRequest, ..Exceptions
using LoggingExtras, CodecZlib, URIs
using SimpleBufferStream: BufferStream
using ConcurrentUtilities: @samethreadpool_spawn

export streamlayer

Expand Down Expand Up @@ -36,7 +37,7 @@ function streamlayer(stream::Stream; iofunction=nothing, decompress::Union{Nothi
# use a lock here for request.context changes (this is currently the only places
# where multiple threads may modify/change context at the same time)
lock = ReentrantLock()
Threads.@spawn try
@samethreadpool_spawn try
writebody(stream, req, lock)
finally
Base.@lock lock begin
Expand All @@ -46,7 +47,7 @@ function streamlayer(stream::Stream; iofunction=nothing, decompress::Union{Nothi
closewrite(stream)
end
read_start = time()
Threads.@spawn try
@samethreadpool_spawn try
@debugv 2 "client startread"
startread(stream)
if !isaborted(stream)
Expand Down

3 comments on commit c495600

@quinnj
Copy link
Member

@quinnj quinnj commented on c495600 Mar 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register()

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/103009

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v1.10.4 -m "<description of version>" c49560060cb7359a4a6ba121940034b0aed17028
git push origin v1.10.4

@samtkaplan
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

Please sign in to comment.