Lower max RSS value on low memory systems #88
+16
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
We should also make this configurable. Julia core has an environment variable: |
This comment was marked as outdated.
This comment was marked as outdated.
giordano
reviewed
Feb 10, 2026
| _max_worker_rss[] | ||
| end | ||
| end | ||
|
|
Collaborator
There was a problem hiding this comment.
This feels a bit overcomplicated to be honest. How about just making it a function, which is passed as default value to a new keyword argument to runtests?
giordano
approved these changes
Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There may be a better way to approach this, but on low memory runners (8GB mac runners), 3800MiB is too high of a limit and it causes issues with code loading times (note how the "init time" increases for no apparent reason in this run.)
3000MiB seems like it prevents these issues without creating new workers constantly.