Skip to content

Fix for complex powers of symbolics #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

karlwessel
Copy link
Contributor

This fixes issue #717

@karlwessel
Copy link
Contributor Author

Anything preventing this from merging?

Copy link
Contributor

github-actions bot commented Jun 3, 2025

Benchmark Results

master 5dbc0d5... master / 5dbc0d5...
overhead/acrule/a+2 1.02 ± 0.32 μs 0.92 ± 0.32 μs 1.11 ± 0.53
overhead/acrule/a+2+b 1.2 ± 0.32 μs 0.904 ± 0.31 μs 1.33 ± 0.58
overhead/acrule/a+b 0.271 ± 0.026 μs 0.23 ± 0.012 μs 1.18 ± 0.13
overhead/acrule/noop:Int 1.56 ± 0.92 ns 1.56 ± 0.01 ns 1 ± 0.59
overhead/acrule/noop:Sym 26.9 ± 5.9 ns 28.3 ± 5.9 ns 0.948 ± 0.29
overhead/rule/noop:Int 0.0365 ± 0.024 μs 0.0361 ± 0.025 μs 1.01 ± 0.97
overhead/rule/noop:Sym 0.0336 ± 0.024 μs 0.0336 ± 0.024 μs 1 ± 1
overhead/rule/noop:Term 0.0337 ± 0.024 μs 0.0334 ± 0.024 μs 1.01 ± 1
overhead/ruleset/noop:Int 0.117 ± 0.0041 μs 0.122 ± 0.0047 μs 0.959 ± 0.05
overhead/ruleset/noop:Sym 0.128 ± 0.0045 μs 0.115 ± 0.0028 μs 1.11 ± 0.047
overhead/ruleset/noop:Term 4.68 ± 0.16 μs 8.03 ± 0.27 μs 0.583 ± 0.028
overhead/simplify/noop:Int 0.215 ± 0.015 μs 0.296 ± 0.03 μs 0.727 ± 0.09
overhead/simplify/noop:Sym 0.219 ± 0.016 μs 0.291 ± 0.03 μs 0.753 ± 0.096
overhead/simplify/noop:Term 0.0487 ± 0.0022 ms 0.0381 ± 0.0017 ms 1.28 ± 0.081
overhead/simplify/randterm (+, *):serial 0.121 ± 0.0043 s 0.0904 ± 0.003 s 1.33 ± 0.065
overhead/simplify/randterm (+, *):thread 0.0695 ± 0.0063 s 0.0505 ± 0.0044 s 1.37 ± 0.17
overhead/simplify/randterm (/, *):serial 0.236 ± 0.022 ms 0.229 ± 0.019 ms 1.03 ± 0.13
overhead/simplify/randterm (/, *):thread 0.272 ± 0.021 ms 0.244 ± 0.018 ms 1.12 ± 0.12
overhead/substitute/a 0.104 ± 0.012 ms 0.157 ± 0.017 ms 0.664 ± 0.11
overhead/substitute/a,b 0.0904 ± 0.011 ms 0.139 ± 0.015 ms 0.651 ± 0.1
overhead/substitute/a,b,c 21.5 ± 2.7 μs 0.0617 ± 0.0043 ms 0.348 ± 0.05
polyform/easy_iszero 0.0414 ± 0.0013 ms 0.0618 ± 0.0012 ms 0.671 ± 0.025
polyform/isone 3.11 ± 0.01 ns 2.79 ± 0.01 ns 1.11 ± 0.0053
polyform/iszero 1.42 ± 0.025 ms 1.95 ± 0.025 ms 0.729 ± 0.016
polyform/simplify_fractions 1.93 ± 0.033 ms 2.66 ± 0.043 ms 0.724 ± 0.017
time_to_load 1.16 ± 0.024 s 1.14 ± 0.016 s 1.02 ± 0.025

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants