Fix test failure with ReinterpretArray #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, there's still another error to fix on 0.7... |
|
Looks like something is or is not null terminated only on 0.7??? |
next(x, endof(x)) is not generally valid with AbstractVectors even though
it works for Vector. This fixes a test failure on Julia 0.7.
The UTF32String(::Vector{Char}) constructor added a \0 char at the end
of the string because it used reinterpret(UInt32, ...), which did not
dispatch to the inner constructor directly as it used to do on 0.6.
|
OK I've found the problem. |
|
Good catch! |
ararslan
approved these changes
Oct 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
next(x, endof(x))is not generally valid with AbstractVectors even thoughit works for Vector. This fixes a test failure on Julia 0.7.
The
UTF32String(::Vector{Char})constructor added a\0char at the end of the string because it usedreinterpret(UInt32, ...), which did not dispatch to the inner constructor directly as it used to do on 0.6.