Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the SpecialFunctions package from 0.8, 0.9 to 0.8, 0.9, 0.10.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

@nalimilan
Copy link
Member

Failure seems to be due to ForwardDiff not allowing the new version.

@DilumAluthge
Copy link
Member

@nalimilan Can you close and re-open this PR to re-trigger Travis?

The latest tagged release of ForwardDiff (https://github.com/JuliaDiff/ForwardDiff.jl/releases/tag/v0.10.9) now allows SpecialFunctions 0.10.

@sethaxen
Copy link
Contributor

I'd like to 2nd the request to get this PR closed and re-opened.

@nalimilan nalimilan closed this Feb 13, 2020
@nalimilan nalimilan reopened this Feb 13, 2020
@sethaxen
Copy link
Contributor

Thanks! Looks like the StackOverflowError on logabsgamma(::Dual{Nothing,Float64,0}) is due to JuliaMath/SpecialFunctions.jl#186, which has a proposed fix in JuliaDiff/ForwardDiff.jl#419.

@andreasnoack
Copy link
Member

The issue was fixed in JuliaDiff/DiffRules.jl@49129c0 but for some reason, the latest version of DiffRules isn't being installed on 1.3. I'll take a look.

@andreasnoack
Copy link
Member

We can restart the tests here once JuliaRegistries/General#9460 has been merged. Hopefully, it won't be necessary with a breaking SpecialFunctions release for a while.

@andreasnoack andreasnoack merged commit 288b2c1 into master Feb 14, 2020
@andreasnoack andreasnoack deleted the compathelper/new_version/2020-01-14-18-05-26-778-2958814553 branch February 14, 2020 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants