Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes:
Inf
.Additional changes:
betapdf
andbetalogpdf
NaN
) at the single point of support, 0 everywhere elseDirac
is treated as a discrete distribution andpdf(::Dirac)
is PMF instead of PDF. PMF is 1, PDF is a value which integrates to 1 at a single point.quantile(::Dirac)
works in Distributions.jlbetacdf(0, 0.5, 0.45)
andbetacdf(0, 0.5, 0.46)
)Primary motivation:
I'm fixing handling of degenerate Beta distributions in Distributions.jl right now, and
median(Beta(Inf, 1))
hangs becausequantile(Beta(Inf, 1), 0.5)
hangs.Between this pull request and one about to be opened in Distributions.jl, degenerate Beta distribution behavior will align with the Dirac distribution behavior, EXCEPT returning pdf = NaN instead of pmf = 1.