Remove code for unsupported Julia versions #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, I think |
Codecov ReportBase: 61.58% // Head: 58.37% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #155 +/- ##
==========================================
- Coverage 61.58% 58.37% -3.21%
==========================================
Files 14 14
Lines 617 543 -74
==========================================
- Hits 380 317 -63
+ Misses 237 226 -11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
The remaining test errors are caused by the recent Rmath update, see #156 |
andreasnoack
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking through tdist.jl, I noticed that there is some code left for nowadays unsupported Julia versions.
Edit: Somehow read 0.7 instead of 1.7, so clearly one of the branches is still needed...
Edit2: Maybe it would actually be better to use
log2mexphere to continue performing operations in log-space.