MulticlassLDA documentation - #202
Merged
Merged
Conversation
The documentation of `fit` function wasn't displayed on documentation.
wildart
reviewed
Aug 20, 2022
Collaborator
|
And example for LDA would be a nice addition. If you decide to submit PR, please follow the structure of PCA docs. |
- Revert the mistake in MulticlassLDA fit function - Fix the documentation of SubspaceLDA fit function
Contributor
Author
|
Thanks for your useful comments. I append the example to the LDA page. |
Collaborator
|
You may want to move example in the beginning on the page, just under the LDA description. So it will show up in TOC in the first place. |
Contributor
Author
Yes it's consistent with the page on principal component analysis. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation of
fitfunction for MulticlassLDA wasn't displayed.I think i fixed it. There is no example for LDA so i made a simple one but I am not sure you want it.
I can add it to the PR it you are interested. This is the scikit-learn example though.