Remove number of classes parameter from *-LDA - #199
Merged
Conversation
…ique labels. Fixes JuliaStats#187.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, in MC-LDA & SubLDA, labels required to be from a set of integers in the range
1:ncwherencis a total number of classes. That created a problem when some labels in this range where not present in the label collection. e.g.[1,1,3,3,3]label collection has two classes but maximum value of label is3. This was intentional design decision because label set was used for indexing features during calculation of feature centers. Thus, to avoid incorrect indexing the number of classes parameter was used.This PR removes the "number of classes" parameter and estimates a number of classes from a number of unique labels. Additionally, PR removes type limitation on label collection.