Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.0 #540

Merged
merged 8 commits into from
Jul 16, 2021
Merged

Release 4.0 #540

merged 8 commits into from
Jul 16, 2021

Conversation

palday
Copy link
Member

@palday palday commented Jul 15, 2021

  • update README (should be easy to adapt highlights from NEWS or maybe just drop the new major release bit and add a reference to NEWS)
  • run JuliaFormatter
  • create a new branch from current main called 4.x (after merging)

@dmbates do you want to take care of the formatting? done!

@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #540 (1032d5b) into main (680aec4) will decrease coverage by 0.04%.
The diff coverage is 94.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #540      +/-   ##
==========================================
- Coverage   94.49%   94.44%   -0.05%     
==========================================
  Files          27       27              
  Lines        2414     2468      +54     
==========================================
+ Hits         2281     2331      +50     
- Misses        133      137       +4     
Impacted Files Coverage Δ
src/linalg.jl 62.82% <68.75%> (+0.97%) ⬆️
src/Xymat.jl 87.50% <81.81%> (ø)
src/schema.jl 80.00% <83.33%> (ø)
src/varcorr.jl 98.27% <87.50%> (-1.73%) ⬇️
src/arraytypes.jl 94.33% <90.00%> (ø)
src/utilities.jl 96.87% <90.00%> (+0.04%) ⬆️
src/mixedmodel.jl 91.48% <91.66%> (ø)
src/randomeffectsterm.jl 96.10% <91.66%> (-1.12%) ⬇️
src/remat.jl 96.70% <93.67%> (+0.06%) ⬆️
src/bootstrap.jl 97.84% <94.11%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 680aec4...1032d5b. Read the comment docs.

@palday palday marked this pull request as ready for review July 15, 2021 06:03
@palday palday requested a review from dmbates July 15, 2021 06:03
Copy link
Collaborator

@dmbates dmbates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • This looks good to go for me whenever you are satisfied.

  • I think that running the code through the formatter was a good idea. Thanks for doing that. In some ways consistency of style is more important than the particular style being used.

@palday palday merged commit 26a87d5 into main Jul 16, 2021
@palday palday deleted the pa/release-4.0 branch July 16, 2021 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants