Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BACKPORT: Markdown show methods for our types #475

Merged
merged 2 commits into from
Feb 26, 2021
Merged

BACKPORT: Markdown show methods for our types #475

merged 2 commits into from
Feb 26, 2021

Conversation

palday
Copy link
Member

@palday palday commented Feb 26, 2021

Backports #474

palday and others added 2 commits February 26, 2021 17:39
* specify plain-text MIME in show methods

* remove redudant method

* markdown show method for VarCorr

* show md blockdescription

* broaden size to work on GLMM

* show md method for MixedModel

* show method for LikelihoodRatioTest

* NEWS entry

* remove unused padding computation

* more usage notes

* not gonna PCA afterall

* remove unused and problematic digits kwarg

* optsummary

* tests

* disable BLAS info on 1.7

* better plain-text readability of markdown for MixedModel, BlockDescription

* force a particular model fit in tests

* fix future guard

* more forcing fit results for textual comparison

* helps if you save your changes

* format tweak

* whyyyy

* variability in printing exponent

(cherry picked from commit f81ccbc)
@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #475 (461787b) into v3.x (8efb077) will increase coverage by 0.51%.
The diff coverage is 98.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##             v3.x     #475      +/-   ##
==========================================
+ Coverage   92.86%   93.38%   +0.51%     
==========================================
  Files          23       24       +1     
  Lines        1738     1889     +151     
==========================================
+ Hits         1614     1764     +150     
- Misses        124      125       +1     
Impacted Files Coverage Δ
src/MixedModels.jl 100.00% <ø> (ø)
src/blockdescription.jl 100.00% <ø> (ø)
src/mdshow.jl 98.62% <98.62%> (ø)
src/generalizedlinearmixedmodel.jl 88.18% <100.00%> (+0.44%) ⬆️
src/likelihoodratiotest.jl 98.68% <100.00%> (+0.01%) ⬆️
src/linearmixedmodel.jl 94.24% <100.00%> (-0.02%) ⬇️
src/mixedmodel.jl 83.33% <100.00%> (+1.51%) ⬆️
src/optsummary.jl 100.00% <100.00%> (ø)
src/randomeffectsterm.jl 94.23% <100.00%> (+0.11%) ⬆️
src/varcorr.jl 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8efb077...d34140a. Read the comment docs.

@palday palday merged commit b00c381 into v3.x Feb 26, 2021
@palday palday deleted the pa/mdbackport branch February 26, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant