Merge glmnetcv from Cox into main function #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves test failures caused by the Cox version not having the same guards against fits of different lengths being return
Codecov Report
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
- Coverage 93.53% 93.27% -0.27%
==========================================
Files 3 3
Lines 464 446 -18
==========================================
- Hits 434 416 -18
Misses 30 30
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #50, I saw some test failures on CI at random due to the RNG tests returning fits of different lengths in rare cases. I realized the Cox version of
glmnetcvdidn't have the same guards against the fits being different lengths.It seemed a clean fix to merge these functions together rather than having all the cross-validation logic duplicated between them.