Residuals in GLM #540
Open
Residuals in GLM #540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR seems to be picking up some older commits and needs cleaning up. |
|
Thanks, Viral. |
* [G]VIF * add reference value source * more tests * glm tests
|
The PR is now cleaned up and merged with the latest master branch. |
bkamins
reviewed
Oct 7, 2023
| import Base: (\), convert, show, size | ||
| import LinearAlgebra: cholesky, cholesky! | ||
| import Statistics: cor | ||
| using StatsAPI |
bkamins
reviewed
Oct 7, 2023
| residuals(obj::LinPredModel) = residuals(obj.rr) | ||
|
|
||
| function formula(obj::LinPredModel) | ||
| function residuals(model::LinPredModel; type=:deviance) |
There was a problem hiding this comment.
I do not know the details of the implementation, but is the residuals method properly documented (as it is not documented here). I.e. that it supports type kwarg and what is the behavior depending on the value of the kwarg.
There was a problem hiding this comment.
It is documented on line 847 of glmfit.jl
|
what's the status of this PR? Can it get a bit of love? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added most of the test cases as discussed in #499.
Also, I have changed the residuals function for
lm. Now the residuals function forlmis similar to residuals function in 'glm'.Although, I am not sure about applicability of
:workingtype residuals inlm.Rsupports:workingtype residuals inlmand which is same as:responsetype.