Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump minimal supported julia version to 1.6 #1901

Closed
wants to merge 2 commits into from
Closed

Bump minimal supported julia version to 1.6 #1901

wants to merge 2 commits into from

Commits on Sep 13, 2024

  1. Bump minimal supported julia version to 1.6 

    In JuliaStats#1900,
dependency on Roots.jl is being added, which only supports julia 1.6+
    @LebedevRI
    LebedevRI committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    133a93e View commit details
    Browse the repository at this point in the history

  2. Disable Aqua tests for julia 1.6 too 

    I *think* this is a false-positive:
```
Running tests:
1 ambiguities found. To get a list, set `broken = false`.
Ambiguity JuliaStats#1
frule(::ChainRulesCore.RuleConfig, args...) in ChainRulesCore at /home/runner/.julia/packages/ChainRulesCore/I1EbV/src/rules.jl:64
frule(::Any, ::typeof(Distributions.logpdf), d::Distributions.Uniform, x::Real) in Distributions.DistributionsChainRulesCoreExt at /home/runner/work/Distributions.jl/Distributions.jl/ext/DistributionsChainRulesCoreExt/univariate/continuous/uniform.jl:1

Possible fix, define
  frule(::ChainRulesCore.RuleConfig, ::typeof(Distributions.logpdf), ::Distributions.Uniform, ::Real)

Aqua: Test Failed at /home/runner/.julia/packages/Aqua/tHrmY/src/ambiguities.jl:78
  Expression: iszero(num_ambiguities)
Stacktrace:
 [1] _test_ambiguities(packages::Vector{Base.PkgId}; broken::Bool, kwargs::Base.Iterators.Pairs{Union{}, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})
   @ Aqua ~/.julia/packages/Aqua/tHrmY/src/ambiguities.jl:78
 [2] _test_ambiguities
   @ ~/.julia/packages/Aqua/tHrmY/src/ambiguities.jl:69 [inlined]
 [3] test_ambiguities(packages::Module; kwargs::Base.Iterators.Pairs{Union{}, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})
   @ Aqua ~/.julia/packages/Aqua/tHrmY/src/ambiguities.jl:28
 [4] test_ambiguities(packages::Module)
   @ Aqua ~/.julia/packages/Aqua/tHrmY/src/ambiguities.jl:28
 [5] macro expansion
   @ ~/work/Distributions.jl/Distributions.jl/test/aqua.jl:19 [inlined]
 [6] macro expansion
   @ /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.6/Test/src/Test.jl:1151 [inlined]
 [7] top-level scope
   @ ~/work/Distributions.jl/Distributions.jl/test/aqua.jl:9
```
    @LebedevRI
    LebedevRI committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    6a2ef5a View commit details
    Browse the repository at this point in the history