Fix eachvariate with zero variates
#1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1819 +/- ##
==========================================
+ Coverage 85.93% 85.95% +0.01%
==========================================
Files 144 144
Lines 8655 8655
==========================================
+ Hits 7438 7439 +1
+ Misses 1217 1216 -1 ☔ View full report in Codecov by Sentry. |
andreasnoack
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the constructor of
Distributions.EachVariatefails when there are zero variates (along at least one dimension). The PR fixes this problem similar to the approach taken forSlicesin https://github.com/JuliaLang/julia/blob/38b81562d79dfa44816bd3ce5b249cad87904587/base/slicearray.jl#L43C1-L43C1.Fixes #1817.