Skip to content

Commit

Permalink
newton(): defer to Roots.jl implementation
Browse files Browse the repository at this point in the history
  • Loading branch information
LebedevRI committed Sep 13, 2024
1 parent 2df55bc commit 46ccaaf
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 2 additions & 0 deletions Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ PDMats = "90014a1f-27ba-587c-ab20-58faa44d9150"
Printf = "de0858da-6303-5e67-8744-51eddeeeb8d7"
QuadGK = "1fd47b50-473d-5c70-9696-f719f8f3bcdc"
Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
Roots = "f2b01f46-fcfa-551c-844a-d8ac1e96c665"
SpecialFunctions = "276daf66-3868-5448-9aa4-cd146d93841b"
Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"
StatsAPI = "82ae8749-77ed-4fe6-ae5f-f523153014b0"
Expand Down Expand Up @@ -48,6 +49,7 @@ PDMats = "0.10, 0.11"
Printf = "<0.0.1, 1"
QuadGK = "2"
Random = "<0.0.1, 1"
Roots = "2"
SparseArrays = "<0.0.1, 1"
SpecialFunctions = "1.2, 2"
StableRNGs = "1"
Expand Down
3 changes: 1 addition & 2 deletions src/quantilealgs.jl
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,7 @@ function newton_impl(Δ, xs::T=mode(d), xrtol::Real=1e-12) where {T}
end

function newton((f,df), xs::T=mode(d), xrtol::Real=1e-12) where {T}
Δ(x) = f(x)/df(x)
return newton_impl(Δ, xs, xrtol)
return find_zero((f,df), xs, Roots.Newton(), xatol=0, xrtol=xrtol, atol=0, rtol=eps(float(T)), maxiters=typemax(Int))
end

function quantile_newton(d::ContinuousUnivariateDistribution, p::Real, xs::Real=mode(d), xrtol::Real=1e-12)
Expand Down

0 comments on commit 46ccaaf

Please sign in to comment.