Hardcode doc edit backlink #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #442 +/- ##
==========================================
- Coverage 85.00% 84.42% -0.59%
==========================================
Files 12 12
Lines 8959 8959
==========================================
- Hits 7616 7564 -52
- Misses 1343 1395 +52 ☔ View full report in Codecov by Sentry. |
|
Closing because @mortenpi is in the process of fixing this upstream. Sorry for the noise. |
|
Hey @LilithHafner what's the status on upstream? Do we want to merge this for now? |
|
The upstream PR merged, but unexpectedly did not fix the issue. It will eventually be fixed upstream, but I don't have a timeline for when. I think it is appropriate to merge this now and revert it once the upstream fix is confirmed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the "edit on github" link at https://docs.julialang.org/en/v1/stdlib/SparseArrays/ is broken (JuliaLang/julia#50035). This PR fixes that link. See also: JuliaLang/julia#51375