cat performance tweaks #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that Union{} is not part of the output possibilities after type-piracy of Base.cat methods.
Refs JuliaLang/julia#50550
This little gadget creates a closure over Type{T} instead of DataType.
Fix JuliaLang/julia#50623
Codecov Report
@@ Coverage Diff @@
## main #422 +/- ##
==========================================
+ Coverage 92.11% 92.41% +0.29%
==========================================
Files 12 12
Lines 7661 7669 +8
==========================================
+ Hits 7057 7087 +30
+ Misses 604 582 -22
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@vtjnash Do we need to get this merged - in that is there urgency? |
vtjnash
commented
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(don't squash)