Skip to content

Update the wrappers for SuiteSparse 7 #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

ViralBShah
Copy link
Member

@ViralBShah ViralBShah commented Mar 10, 2023

Try to update the SuiteSparse wrappers for SuiteSparse 7 using Julia master. Address #359

cc @fxcoudert

@ViralBShah
Copy link
Member Author

ViralBShah commented Mar 10, 2023

@Gnimuc Would the generator.jl file for generating the SuiteSparse wrappers need to be updated for the new Clang.jl? The script runs through with Julia master, but in the generated files, there are various C constants like int64_t, LONG_MAX, __STDC_VERSION__ etc.

I am running the generator on the SuiteSparse 7 update branch on Julia - JuliaLang/julia#48855.

Help appreciated.

@Gnimuc
Copy link
Member

Gnimuc commented Mar 11, 2023

Please do not bump Clang.jl's minor version and the C lib's major version simultaneously. It's hard to figure out what causes the changes in the generated result.

@Gnimuc
Copy link
Member

Gnimuc commented Mar 11, 2023

@Wimmerer does SuiteSparse 7 introduce breaking changes? I mean we may need to upgrade those high-level wrappers as well.

@rayegun
Copy link
Member

rayegun commented Mar 11, 2023

Very possibly. I need to examine what we do with SuiteSparse_config

@rayegun
Copy link
Member

rayegun commented Mar 11, 2023

I will try to do that tonight

@ViralBShah
Copy link
Member Author

I believe @fxcoudert implement that change relating to the API change with the config strict in one of the recent PRs to this package.

There may be other changes.

@ViralBShah
Copy link
Member Author

Please do not bump Clang.jl's minor version and the C lib's major version simultaneously. It's hard to figure out what causes the changes in the generated result.

Makes sense. I wasn't sure how to do this. We should close this PR.

@ViralBShah ViralBShah closed this Mar 11, 2023
@Gnimuc
Copy link
Member

Gnimuc commented Mar 11, 2023

I tested the generator locally. The generated results have no changes after bumping Clang.jl from v0.15 to v0.17.

@Gnimuc
Copy link
Member

Gnimuc commented Mar 11, 2023

But I failed to upgrade SuiteSparse_jll to v7.0.1:

(gen) pkg> add SuiteSparse_jll@v7.0.1
   Resolving package versions...
  No Changes to `~/.julia/dev/SparseArrays.jl/gen/Project.toml`
  No Changes to `~/.julia/dev/SparseArrays.jl/gen/Manifest.toml`

(gen) pkg> st
Status `~/.julia/dev/SparseArrays.jl/gen/Project.toml`
  [40e3b903] Clang v0.17.3
  [bea87d4a] SuiteSparse_jll v5.10.1+6

@ViralBShah
Copy link
Member Author

Yes, because it is an stdlib, it gets pinned. I find it easiest to disable it in the system image and then bump the version on Julia master. I have a local copy that I can provide as a branch.

@ViralBShah
Copy link
Member Author

@Gnimuc I have prepared JuliaLang/julia#48977, which should make it easy to update these wrappers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants