-
Notifications
You must be signed in to change notification settings - Fork 62
Update the wrappers for SuiteSparse 7 #362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Gnimuc Would the generator.jl file for generating the SuiteSparse wrappers need to be updated for the new Clang.jl? The script runs through with Julia master, but in the generated files, there are various C constants like I am running the generator on the SuiteSparse 7 update branch on Julia - JuliaLang/julia#48855. Help appreciated. |
This reverts commit 4179450.
36fb169
to
ba7eb37
Compare
Please do not bump Clang.jl's minor version and the C lib's major version simultaneously. It's hard to figure out what causes the changes in the generated result. |
@Wimmerer does SuiteSparse 7 introduce breaking changes? I mean we may need to upgrade those high-level wrappers as well. |
Very possibly. I need to examine what we do with SuiteSparse_config |
I will try to do that tonight |
I believe @fxcoudert implement that change relating to the API change with the config strict in one of the recent PRs to this package. There may be other changes. |
Makes sense. I wasn't sure how to do this. We should close this PR. |
I tested the generator locally. The generated results have no changes after bumping Clang.jl from v0.15 to v0.17. |
But I failed to upgrade
|
Yes, because it is an stdlib, it gets pinned. I find it easiest to disable it in the system image and then bump the version on Julia master. I have a local copy that I can provide as a branch. |
@Gnimuc I have prepared JuliaLang/julia#48977, which should make it easy to update these wrappers. |
Try to update the SuiteSparse wrappers for SuiteSparse 7 using Julia master. Address #359
cc @fxcoudert