-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backports for Julia v1.8.x #252
Conversation
Co-authored-by: Steven G. Johnson <stevenj@mit.edu>
x-ref #245 (I followed the instructions literally in the backport action error message, so it has slightly different source and target branches). |
Did that one pass tests? I'm not sure what the issue is with this one, maybe I didn't do it right. I just followed #249 without realizing you had already done the backport. We should collect #93 and #253 on a single |
Do you do |
Codecov Report
@@ Coverage Diff @@
## release-1.8 #252 +/- ##
===============================================
- Coverage 89.16% 89.05% -0.12%
===============================================
Files 7 7
Lines 5667 5673 +6
===============================================
- Hits 5053 5052 -1
- Misses 614 621 +7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Yes iirc |
@dkarrasch we just need the circshift changes here right? Then we're good to merge? |
(cherry picked from commit 4fb8f0e)
It turns out we also have #176 labelled for backport. |
Please push an update to JuliaLang/julia#46663 when this is done. |
I only know how this works with BumpStdlibs.jl, is that used here? |
I guess now we should wait for the clean-up PR for circshift, right? Otherwise, I don't see anything on the horizon that needs action. |
circshift and I need to fix two typos I found. Then we're good. |
The release of v1.8.2 has been announced, and we really should get the backports in. Do we need to include anything else? Or shall we merge this and go ahead on the Julia Base side? |
I think this is ready to go @dkarrasch |
I'm gonna merge this now so that it doesn't miss 1.8.3 as well. |
Co-authored-by: Steven G. Johnson stevenj@mit.edu
Note: I want to be sure the attribution is correct here, I think it should say "authored by Jerry and Steven" and "committed by Wimmerer".
Backported PRs:
vcat
of sparse vectors with numbers #253length(::SparseVector{Tv,Ti})
returnTi
#176