Backports for Julia v1.8.x

[rayegun]

Co-authored-by: Steven G. Johnson stevenj@mit.edu

Note: I want to be sure the attribution is correct here, I think it should say "authored by Jerry and Steven" and "committed by Wimmerer".

Backported PRs:

• fix findmin/findmax #93
• Fix vcat of sparse vectors with numbers #253
• Fix direction of circshift #260
• Let length(::SparseVector{Tv,Ti}) return Ti #176

[dkarrasch]

x-ref #245 (I followed the instructions literally in the backport action error message, so it has slightly different source and target branches).

[rayegun]

Did that one pass tests? I'm not sure what the issue is with this one, maybe I didn't do it right. I just followed #249 without realizing you had already done the backport. We should collect #93 and #253 on a single release-1.8 branch at some point before adjusting julialang/julia according to #249.

[KristofferC]

Note: I want to be sure the attribution is correct here, I think it should say "authored by Jerry and Steven" and "committed by Wimmerer".

Do you do git cherry-pick -x COMMIT?

[codecov-commenter]

Codecov Report

Merging #252 (f7dc713) into release-1.8 (aa51c9b) will decrease coverage by 0.11%.
The diff coverage is 86.95%.

@@               Coverage Diff               @@
##           release-1.8     #252      +/-   ##
===============================================
- Coverage        89.16%   89.05%   -0.12%     
===============================================
  Files                7        7              
  Lines             5667     5673       +6     
===============================================
- Hits              5053     5052       -1     
- Misses             614      621       +7     

Impacted Files	Coverage Δ
src/SparseArrays.jl	100.00% <ø> (ø)
src/sparsevector.jl	94.19% <84.21%> (+0.02%)	⬆️
src/sparsematrix.jl	94.74% <100.00%> (-0.31%)	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[rayegun]

Yes iirc

[rayegun]

@dkarrasch we just need the circshift changes here right? Then we're good to merge?

[dkarrasch]

It turns out we also have #176 labelled for backport.

[KristofferC]

Please push an update to JuliaLang/julia#46663 when this is done.

[rayegun]

I only know how this works with BumpStdlibs.jl, is that used here?

[dkarrasch]

I guess now we should wait for the clean-up PR for circshift, right? Otherwise, I don't see anything on the horizon that needs action.

[rayegun]

circshift and I need to fix two typos I found. Then we're good.

[dkarrasch]

The release of v1.8.2 has been announced, and we really should get the backports in. Do we need to include anything else? Or shall we merge this and go ahead on the Julia Base side?

[rayegun]

I think this is ready to go @dkarrasch

[KristofferC]

I'm gonna merge this now so that it doesn't miss 1.8.3 as well.