-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make lu! reuse working buffers #179
Conversation
@ViralBShah is there any reason to not merge this and the qsymbolic patch atm? (after CI of-course) both are non-breaking |
Yes, let's merge. I'll let you go about the merging to minimize conflicts if there are. |
i think this should go first but i think there are a bunch of conflicts..i'll fix them after you merged this one. |
also if you meant that i should do the merges myself, i don't have write access |
Codecov Report
@@ Coverage Diff @@
## main #179 +/- ##
==========================================
+ Coverage 34.25% 36.50% +2.25%
==========================================
Files 25 25
Lines 21127 21899 +772
==========================================
+ Hits 7237 7995 +758
- Misses 13890 13904 +14
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
I thought I had given you write access - Seems like I still haven't understood the latest iteration of github permissioning. Anyways, added you now - you should be able to merge. |
had to close #104 due to ... issues with git.