Skip to content

move USE_GPL_LIBS check to the solver files #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 22, 2022
Merged

Conversation

ViralBShah
Copy link
Member

@ViralBShah ViralBShah commented Jun 22, 2022

include all the solvers tests in testgroups
move basetests.jl into issues.jl

@ViralBShah ViralBShah requested a review from rayegun June 22, 2022 03:11
Copy link
Member

@rayegun rayegun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I had some troubles with missing imports here and there, but if no tests fail on that this is good.

@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2022

Codecov Report

Merging #154 (492c785) into main (ee38766) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
+ Coverage   34.20%   34.24%   +0.03%     
==========================================
  Files          25       25              
  Lines       21121    21121              
==========================================
+ Hits         7224     7232       +8     
+ Misses      13897    13889       -8     
Impacted Files Coverage Δ
src/linalg.jl 84.58% <0.00%> (+0.08%) ⬆️
src/sparsematrix.jl 95.32% <0.00%> (+0.30%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@ViralBShah ViralBShah merged commit 176ef64 into main Jun 22, 2022
@ViralBShah ViralBShah deleted the vs/solvers-tests branch June 22, 2022 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants