Skip to content

Conversation

@MohamedLaghdafHABIBOULLAH
Copy link
Contributor

@dpo With these changes, push! for diagonal QN operator should no longer allocate memory.

julia> using LinearOperators

julia> D = DiagonalAndrei(ones(2));

julia> s0 = sqrt(3) * ones(2)

julia> y0 = sqrt(2) *ones(2)

julia> @wrappedallocs push!(D, s0, y0)
0

julia> D = DiagonalPSB(ones(2))

julia> @wrappedallocs push!(D, s0, y0)
0

julia> D = SpectralGradient(1., 2);

julia> @wrappedallocs push!(D, s0, y0)
0

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

Package name latest stable
CaNNOLeS.jl
DCISolver.jl
FletcherPenaltySolver.jl
JSOSolvers.jl
Krylov.jl
NLPModels.jl
NLPModelsModifiers.jl
PROPACK.jl
Percival.jl
QuadraticModels.jl
SolverTools.jl

@dpo
Copy link
Member

dpo commented Sep 9, 2024

We're still missing @wrappedallocs and unit tests, right?

@MohamedLaghdafHABIBOULLAH
Copy link
Contributor Author

MohamedLaghdafHABIBOULLAH commented Oct 7, 2024

@dpo I have added wrappedallocs and a unit test for the new versions of diagonal push, and I removed the unused iterators

Co-authored-by: Dominique <dominique.orban@gmail.com>
Co-authored-by: Dominique <dominique.orban@gmail.com>
Co-authored-by: Dominique <dominique.orban@gmail.com>
Co-authored-by: Dominique <dominique.orban@gmail.com>
Co-authored-by: Dominique <dominique.orban@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants