Add reset function for Diagonal QN operators, fix bug SpectralGradient #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 97.38% // Head: 97.42% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #266 +/- ##
==========================================
+ Coverage 97.38% 97.42% +0.03%
==========================================
Files 14 14
Lines 996 1009 +13
==========================================
+ Hits 970 983 +13
Misses 26 26
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Contributor
|
tmigot
approved these changes
Jan 26, 2023
Member
tmigot
left a comment
tmigot
left a comment
There was a problem hiding this comment.
Looks great, thanks! After the two suggested changes, it's good for me.
Co-authored-by: tmigot <tangi.migot@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following JuliaSmoothOptimizers/NLPModelsModifiers.jl#94, I added
reset!functions that restore the QN operators to the identity operator.At the same time, I spotted a bug with
SpectralGradientwhere the push was not updatingdin the closureprod = (res, v, α, β) -> mulSquareOpDiagonal!(res, d, v, α, β)(becausedwas a Real).I fixed it by changing
dto[σ]so that modifyingd[1]modifiesmulSquareOpDiagonal!(res, d, v, α, β)accordingly.This modifies the way we update a
SpectralGradient: we have to doop.d[1] = 2.0instead ofop.d = 2.0, but since we are supposed to update this operator withpush!, this should not break code.Does the adding of the
reset!function requires a new minor release2.6.0, or can we stick to a patch2.5.1?