Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with Julia 1.7 #298

Merged
merged 1 commit into from
May 17, 2021

Conversation

amontoison
Copy link
Member

No description provided.

@github-actions
Copy link
Contributor

Package name latest stable
CaNNOLeS.jl
DCI.jl
JSOSolvers.jl
Percival.jl

@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #298 (1e1fad3) into master (681a87d) will not change coverage.
The diff coverage is 85.71%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #298   +/-   ##
=======================================
  Coverage   96.20%   96.20%           
=======================================
  Files          33       33           
  Lines        3978     3978           
=======================================
  Hits         3827     3827           
  Misses        151      151           
Impacted Files Coverage Δ
src/krylov_utils.jl 74.64% <85.71%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 681a87d...1e1fad3. Read the comment docs.

@dpo
Copy link
Member

dpo commented May 13, 2021

Great. I was wondering about those failures. There’s still something related to LinearOperators though :-(

@amontoison
Copy link
Member Author

Let's wait the official release 1.7 to see if we still have the same issues.

@amontoison amontoison closed this May 13, 2021
@amontoison
Copy link
Member Author

amontoison commented May 13, 2021

Great. I was wondering about those failures. There’s still something related to LinearOperators though :-(

The issue is related to the function length of SparseVector{Float32, Int32} that returns Int32 now. I think that it's a bug because we still have Int64 with Float32 dense vectors.

@amontoison
Copy link
Member Author

amontoison commented May 14, 2021

I found the culprit : JuliaLang/julia#39645. It's not a bug.

@amontoison amontoison reopened this May 14, 2021
@github-actions
Copy link
Contributor

Package name latest stable
CaNNOLeS.jl
DCI.jl
JSOSolvers.jl
Percival.jl

@amontoison
Copy link
Member Author

nrow and ncol attributes of LinearOperators should be Integer instead of Int.
@geoffroyleconte Can you take this into account for the revamp ?

@amontoison amontoison merged commit fab0f0a into JuliaSmoothOptimizers:master May 17, 2021
@amontoison amontoison deleted the integer_1.7 branch August 4, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants