Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced CITATION.bib by CITATION.cff #87

Merged
merged 10 commits into from
Feb 9, 2024

Conversation

Jay-sanjay
Copy link
Contributor

This PR address #86

closes #86

Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jay-sanjay for the suggestion, hère are some comments

CITATION.cff Show resolved Hide resolved
CITATION.cff Outdated Show resolved Hide resolved
CITATION.cff Outdated Show resolved Hide resolved
CITATION.cff Outdated Show resolved Hide resolved
CITATION.cff Outdated Show resolved Hide resolved
CITATION.cff Outdated Show resolved Hide resolved
Jay-sanjay and others added 6 commits February 7, 2024 02:27
Co-authored-by: tmigot <tangi.migot@gmail.com>
Co-authored-by: tmigot <tangi.migot@gmail.com>
Co-authored-by: tmigot <tangi.migot@gmail.com>
Co-authored-by: tmigot <tangi.migot@gmail.com>
Co-authored-by: tmigot <tangi.migot@gmail.com>
Co-authored-by: tmigot <tangi.migot@gmail.com>
@Jay-sanjay
Copy link
Contributor Author

Thank you for the suggestions sir.

@tmigot
Copy link
Member

tmigot commented Feb 6, 2024

Could you also update the links in the readme.md and https://github.com/Jay-sanjay/BundleAdjustmentModels.jl/blob/cff/docs/src/index.md to point to CFF and not BIB?

@tmigot
Copy link
Member

tmigot commented Feb 9, 2024

@software{Kenens_BundleAdjustmentModels_jl_Julia_repository_2023,
author = {Kenens, Antonin and Orban, Dominique and {contributors}},
license = {MPL-2.0},
month = mar,
title = {{BundleAdjustmentModels.jl: Julia repository of bundle adjustment problems}},
url = {https://github.com/JuliaSmoothOptimizers/BundleAdjustmentModels.jl},
version = {0.3.2},
year = {2023}
}

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9585863) 92.54% compared to head (6980b2b) 92.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #87   +/-   ##
=======================================
  Coverage   92.54%   92.54%           
=======================================
  Files           5        5           
  Lines         295      295           
=======================================
  Hits          273      273           
  Misses         22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tmigot tmigot merged commit cc7bc62 into JuliaSmoothOptimizers:main Feb 9, 2024
13 of 15 checks passed
@Jay-sanjay Jay-sanjay deleted the cff branch April 2, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace CITATION.bib by CITATION.cff
2 participants