Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid broadcast in residual function #84

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Avoid broadcast in residual function #84

merged 1 commit into from
Jun 19, 2024

Conversation

tmigot
Copy link
Member

@tmigot tmigot commented Jul 13, 2023

So that, we can use AD with the residual function

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.17 🎉

Comparison is base (9585863) 92.54% compared to head (cda0ea5) 92.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   92.54%   92.71%   +0.17%     
==========================================
  Files           5        5              
  Lines         295      302       +7     
==========================================
+ Hits          273      280       +7     
  Misses         22       22              
Impacted Files Coverage Δ
src/BundleAdjustmentNLSFunctions.jl 97.36% <100.00%> (+0.17%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tmigot tmigot mentioned this pull request Oct 1, 2023
@amontoison amontoison merged commit 98d4699 into main Jun 19, 2024
@amontoison amontoison deleted the avoid-broadcast branch June 19, 2024 02:24
@dpo
Copy link
Member

dpo commented Jun 20, 2024

Really? Can’t AD deal with broadcast???

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants