Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

work-a-round bug in Juila <1.9.2 #34

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

samtkaplan
Copy link
Contributor

@samtkaplan samtkaplan commented Mar 12, 2024

In Julia 1.9.0 and 1.9.1, Threads.@spawn Threads.threadpool() 1 does not work. This is a quick+easy work-a-round. see #33.

ref: JuliaLang/julia#50182

Apparently in Julia 1.9.0 and 1.9.1, `Threads.@Spawn Threads.threadpool() 1` does not work.
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.54%. Comparing base (89c13cc) to head (22940b3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   89.86%   90.54%   +0.67%     
==========================================
  Files           8        8              
  Lines         365      370       +5     
==========================================
+ Hits          328      335       +7     
+ Misses         37       35       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omus
Copy link

omus commented Mar 12, 2024

Don't forget the package version bump

@quinnj quinnj merged commit 8307f66 into JuliaServices:main Mar 12, 2024
6 checks passed
@Mrbigmatt
Copy link

Thanks all for a quick resolution on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants