Do not migrate tasks to a different thread pool #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the try_with_timeout method so that it does not migrate a task to a different thread pool.
quinnj
approved these changes
Mar 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
==========================================
+ Coverage 89.86% 90.24% +0.38%
==========================================
Files 8 8
Lines 365 369 +4
==========================================
+ Hits 328 333 +5
+ Misses 37 36 -1 ☔ View full report in Codecov by Sentry. |
quinnj
reviewed
Mar 11, 2024
| @@ -4,6 +4,14 @@ export Lockable, OrderedSynchronizer, reset!, ReadWriteLock, readlock, readunloc | |||
| Workers, remote_eval, remote_fetch, Worker, terminate!, WorkerTerminatedException, | |||
| Pool, acquire, release, drain!, try_with_timeout, TimeoutException | |||
|
|
|||
| macro samethreadpool_spawn(expr) | |||
| if isdefined(Base.Threads, :threadpool) | |||
| esc(:(Threads.@spawn Threads.threadpool() $expr)) | |||
There was a problem hiding this comment.
@kpamnany, do you know why Threads.@spawn doesn't do this by default?
There was a problem hiding this comment.
The thinking was that the default behavior should be to spawn to the default thread pool and you need to explicitly spawn an interactive task because they have an implicit contract to not hog the CPU. For backward compatibility, the contract cannot be assumed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that the
try_with_timeoutmethod runs its task on the same thread pool that that it is executed from. For example, iftry_with_timeoutis called from an interactive thread, then it is a good guess that we want the function being run to also execute in the interactive thread pool, and not the default thread pool.This is one half of a fix for HTTP.jl#1153.
I will make another pull request to HTTP.jl with the other half of the fix.The other half of the fix is JuliaWeb/HTTP.jl#1159.