Skip to content

CompatHelper: bump compat for Static to 0.7, (keep existing compat) #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 6, 2022

This pull request changes the compat entry for the Static package from 0.3, 0.4, 0.6 to 0.3, 0.4, 0.6, 0.7.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@chriselrod chriselrod force-pushed the compathelper/new_version/2022-06-06-01-07-45-075-00418076010 branch from 82ce0c1 to 13c1e56 Compare June 6, 2022 01:07
@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #51 (5c96e79) into main (87be255) will decrease coverage by 2.16%.
The diff coverage is n/a.

❗ Current head 5c96e79 differs from pull request most recent head fafd153. Consider uploading reports for the commit fafd153 to get more accurate results

@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
- Coverage   63.51%   61.35%   -2.17%     
==========================================
  Files           4        4              
  Lines         233      207      -26     
==========================================
- Hits          148      127      -21     
+ Misses         85       80       -5     
Impacted Files Coverage Δ
src/miscellaneous.jl 56.36% <0.00%> (-7.82%) ⬇️
src/broadcast.jl 73.25% <0.00%> (-2.02%) ⬇️
src/blas.jl 24.39% <0.00%> (+0.47%) ⬆️
src/rand.jl 92.00% <0.00%> (+3.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87be255...fafd153. Read the comment docs.

@ranocha
Copy link
Member

ranocha commented Jul 1, 2022

Octavian.jl and LoopVectorization.jl have been updated, so it may be worth running CI again?

@chriselrod chriselrod enabled auto-merge (rebase) July 1, 2022 18:02
@chriselrod chriselrod closed this Jul 1, 2022
auto-merge was automatically disabled July 1, 2022 18:29

Pull request was closed

@chriselrod chriselrod reopened this Jul 1, 2022
@chriselrod
Copy link
Member

The tests don't seem to be triggering.

@chriselrod chriselrod merged commit a07cbf2 into main Jul 1, 2022
@chriselrod chriselrod deleted the compathelper/new_version/2022-06-06-01-07-45-075-00418076010 branch July 1, 2022 19:06
@chriselrod
Copy link
Member

Not sure why CI hasn't been running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants